Fix up packaging of wapm on Windows #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Jan 11, 2021
| mkdir -p "package/bin" | ||
| ifneq ($(OS), Windows_NT) | ||
| if [ -d "wapm-cli" ]; then \ | ||
| cp wapm-cli/target/release/wapm package/bin/ ;\ |
There was a problem hiding this comment.
I think we need to move this up too
There was a problem hiding this comment.
I tried to but I couldn't get the ifneq working internally because the outer conditional was bash, so I settled to just duplicate it!
MarkMcCaskey
force-pushed
the
fix/wapm-packaging-on-windows
branch
from
22b00c9 to
33d9f74
Compare
syrusakbary
approved these changes
Jan 11, 2021
|
bors r+ |
|
bors r- |
|
Canceled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to work on Windows
resolves #1988, resolves half of #1971
Review